Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for deploying to dev-green #691

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

PaulJKim
Copy link
Collaborator

Summary of changes

Adds a new GH workflow for deploying to Realtime Signs dev-green.

Note: The dev-green environment is not set up yet as of 9/12. Currently working with infra to do that.

@PaulJKim
Copy link
Collaborator Author

Question for @paulswartz - If I recall correctly, on-prem deploys to prod do not build a docker image and re-use the latest one that was deployed to dev. If we instituted a dev-green environment and this new GH workflow for deploying to it, could that cause dev-green images to potentially get deployed to prod if dev-green was the last environment deployed to by someone rather than dev?

@github-actions
Copy link

Coverage of commit 6b237a0

Summary coverage rate:
  lines......: 75.4% (1915 of 2539 lines)
  functions..: 76.9% (518 of 674 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@paulswartz
Copy link
Member

@PaulJKim the prod deploy still uses the SHA of the branch being deployed, so as long as you're only deploying main to prod, you should be fine.

Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PaulJKim PaulJKim merged commit b357649 into main Sep 14, 2023
1 check passed
@PaulJKim PaulJKim deleted the pk/dev-green-workflows branch September 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants